Add pthread mutex deadlock detection for debug builds #24607
Merged
+57
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
deadlock_detection
branch
from
a57b588 to
0e10a5e
Compare
sbc100
force-pushed
the
deadlock_detection
branch
from
0e10a5e to
efb88c5
Compare
kripken
reviewed
Jun 19, 2025
sbc100
force-pushed
the
deadlock_detection
branch
from
efb88c5 to
a8d3d3f
Compare
kripken
reviewed
Jun 20, 2025
sbc100
force-pushed
the
deadlock_detection
branch
from
a8d3d3f to
e59d085
Compare
|
I tried out this change and it does cause an assert in |
sbc100
force-pushed
the
deadlock_detection
branch
2 times, most recently
from
c06ae77 to
cf6ce4a
Compare
sbc100
force-pushed
the
deadlock_detection
branch
3 times, most recently
from
2b24c68 to
264052a
Compare
This would really have helped in at least detecting the deadlock that was found in emscripten-core#24570 / emscripten-core#24565
sbc100
force-pushed
the
deadlock_detection
branch
from
264052a to
42fb00c
Compare
kripken
reviewed
Jul 9, 2025
| // We can get here for normal mutexes too, but only in debug builds | ||
| // (where we track ownership purely for debug purposed). | ||
| if ((type & 15) == PTHREAD_MUTEX_NORMAL) return 0; | ||
| #endif |
There was a problem hiding this comment.
How can we get here? Is it because of one of the changes in this PR?
There was a problem hiding this comment.
Yes, prior to this change normal mutex's never make it here since they don't need to track ownership.
Co-authored-by: Alon Zakai <alonzakai@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would really have helped in at least detecting the deadlock that was found in #24570 / #24565